This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Fix url of End 2 End tests guide #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add ngApp directive to bootstrap the app - add simple template with an expression
- Added static html list with two phones into index.html
- Converted the static html list into dynamic one by:
- creating PhoneListCtrl controller for the application
- extracting the data from HTML into a the controller as an in-memory
dataset
- converting the static document into a template with the use of
`[ngRepeat]` [directive] which iterates over the dataset with phones,
clones the ngRepeat template for each instance and renders it into the
view
- Added a simple unit test to show off how to write tests and run them
with Karma (see README.md for instructions)
- Added a search box to demonstrate how: - the data-binding works on input fields - to use [filter] filter - [ngRepeat] automatically shrinks and grows the number of phones in the view - Added an end-to-end test to: - show how end-to-end tests are written and used - to prove that the search box and the repeater are correctly wired together
- Add "age" property to the phone model - Add select box to control phone list order - Override the default order value in controller - Add unit and e2e test for this feature Closes angular#213
- Replaced the in-memory dataset with data loaded from the server (in the form of static phone.json file to make this tutorial backend agnostic) - The json file is loaded using the [$http] service - Demonstrate the use of [services][service] and [dependency injection][DI] - The [$http] is injected into the controller through [dependency injection][DI] (Added inline annotation - thanks to @guatebus - closes angular#207)
- adding phone image and links to phone pages - add end2end test that verifies our phone links - css to style the page just a notch
- Introduce the [$route] service which allows binding URLs for deep-linking with
views
- Create PhoneCatCtrl which governs the entire app and contains $route
configuration
- Load the ngRoute module
- Map `/phones' to PhoneListCtrl and partails/phones-list.html
- Map `/phones/<phone-id>' to PhoneDetailCtrl and partails/phones-detail.html
- Copy deep linking parameters to root controller `params` property for access
in sub controllers
- Replace content of index.html with [ngView] directive
- Create phone list route
- Preserve existing PhoneListCtrl controller
- Move existing html from index.html to partials/phone-list.html
- Create phone details route
- Empty placeholder PhoneDetailsCtrl controller
- Empty placeholder partials/phane-details.html template
- Fetch data for and render phone detail view
- PhoneDetailCtrl controller to fetch details json with [$http] for a specific
phone
- template for the phone detailed view
- CSS to make the phone details page look "pretty"
- Added custom checkmark filter - Update phone detail template to use checkmark filter - Added spec for the filter
In the phone detail view, clicking on a thumbnail image, changes the main phone image to be the large version of the thumbnail image. - Define mainImageUrl model variable in the PhoneDetailCtrl and set its default value - Create setImage controller method to change mainImageUrl - Register ng:click handler for thumb images to use setImage controller method - Add e2e tests for this feature - Add css to change the mouse cursor when user points at thumnail images
- Replaced [$http] with [$resource] - Created a custom Phone service that represents the $resource client
petebacondarwin
force-pushed
the
master
branch
from
5e54104 to
97a4aa5
Compare
gkalpak
added a commit
to gkalpak/angular-phonecat
that referenced
this pull request
Apr 11, 2016
…s for the post-1.5.0 era This commit and the accompanying updates to the tutorial steps constitute a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. -- This was inspired by (and loosely based on) angular#289. Mad props to @teropa for leading the way :) Fixes angular#198 Fixes angular#214 Fixes angular#224 Fixes angular#230 Fixes angular#243 Fixes angular#246 Fixes angular#252 Fixes angular#277 Fixes angular#286 Fixes angular#295 Fixes angular#303 Fixes angular#304 Fixes angular#323 Fixes angular#324 Closes angular#268 Closes angular#270 Closes angular#278 Closes angular#280 Closes angular#289 Closes angular#309 Closes angular#311 Closes angular#319
gkalpak
added a commit
to gkalpak/angular-phonecat
that referenced
this pull request
Apr 11, 2016
…s for the post-1.5.0 era This commit and the accompanying updates to the tutorial steps constitute a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). -- This was inspired by (and loosely based on) angular#289. Mad props to @teropa for leading the way :) -- The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved in the `pre-v1.5.0-snapshot` branch. The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. Fixes angular#198 Fixes angular#214 Fixes angular#224 Fixes angular#230 Fixes angular#243 Fixes angular#246 Fixes angular#252 Fixes angular#277 Fixes angular#286 Fixes angular#295 Fixes angular#303 Fixes angular#304 Fixes angular#323 Fixes angular#324 Closes angular#268 Closes angular#270 Closes angular#278 Closes angular#280 Closes angular#289 Closes angular#309 Closes angular#311 Closes angular#319
gkalpak
added a commit
to gkalpak/angular-phonecat
that referenced
this pull request
Apr 11, 2016
…s for the post-1.5.0 era This commit and the accompanying updates to the tutorial steps constitute a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). BTW, I have tested with the following versions on Node (on Windows 10) and everything seems to work fine: * 0.11.16 * 4.2.6 * 4.4.2 * 5.10.0 -- This was inspired by (and loosely based on) angular#289. Mad props to @teropa for leading the way :) -- The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved in the `pre-v1.5.0-snapshot` branch. The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. Fixes angular#198 Fixes angular#214 Fixes angular#224 Fixes angular#230 Fixes angular#243 Fixes angular#246 Fixes angular#252 Fixes angular#277 Fixes angular#286 Fixes angular#295 Fixes angular#303 Fixes angular#304 Fixes angular#323 Fixes angular#324 Closes angular#268 Closes angular#270 Closes angular#278 Closes angular#280 Closes angular#289 Closes angular#309 Closes angular#311 Closes angular#319
gkalpak
added a commit
to gkalpak/angular-phonecat
that referenced
this pull request
Apr 12, 2016
…s for the post-1.5.0 era This commit and the accompanying updates to the tutorial steps constitute a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process, several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked fine: * 0.11.16 * 4.2.6 * 4.4.2 * 5.10.0 -- This was inspired by (and loosely based on) angular#289. Mad props to @teropa for leading the way :) -- **Note:** The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved on the `pre-v1.5.0-snapshot` branch. The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. -- Related to angular/angular.js#14416. Related to angular/angular-seed#329. Related to angular/angular-seed#333. --- Fixes angular#198 Fixes angular#214 Fixes angular#224 Fixes angular#230 Fixes angular#243 Fixes angular#246 Fixes angular#252 Fixes angular#277 Fixes angular#286 Fixes angular#295 Fixes angular#303 Fixes angular#304 Fixes angular#323 Fixes angular#324 Closes angular#268 Closes angular#270 Closes angular#278 Closes angular#280 Closes angular#289 Closes angular#309 Closes angular#311 Closes angular#319
gkalpak
added a commit
that referenced
this pull request
May 24, 2016
…s for the post-1.5.0 era This commit and the accompanying updates to the tutorial steps constitute a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process, several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked fine: * 0.11.16 * 4.2.6 * 4.4.2 * 5.10.0 -- This was inspired by (and loosely based on) #289. Mad props to @teropa for leading the way :) -- **Note:** The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved on the `pre-v1.5.0-snapshot` branch. The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. -- Related to angular/angular.js#14416. Related to angular/angular-seed#329. Related to angular/angular-seed#333. --- Fixes #198 Fixes #214 Fixes #224 Fixes #230 Fixes #243 Fixes #246 Fixes #252 Fixes #277 Fixes #286 Fixes #295 Fixes #303 Fixes #304 Fixes #323 Fixes #324 Closes #268 Closes #270 Closes #278 Closes #280 Closes #289 Closes #309 Closes #311 Closes #319
gkalpak
added a commit
that referenced
this pull request
May 24, 2016
…s for the post-1.5.0 era This commit and the accompanying updates to the tutorial steps constitute a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process, several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked fine: * 0.11.16 * 4.2.6 * 4.4.2 * 5.10.0 -- This was inspired by (and loosely based on) #289. Mad props to @teropa for leading the way :) -- **Note:** The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved on the `pre-v1.5.0-snapshot` branch. The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. -- Related to angular/angular.js#14416. Related to angular/angular-seed#329. Related to angular/angular-seed#333. --- Fixes #198 Fixes #214 Fixes #224 Fixes #230 Fixes #243 Fixes #246 Fixes #252 Fixes #277 Fixes #286 Fixes #295 Fixes #303 Fixes #304 Fixes #323 Fixes #324 Closes #268 Closes #270 Closes #278 Closes #280 Closes #289 Closes #309 Closes #311 Closes #319
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.