feat($exceptionHandlerProvider): add mode logAndRethrow

[DavidSouther]

Mode logAndRethrow captures the logged exception for later inspection by test
assertions, while also throwing the exception for when the implementation
depends on thrown behavior (eg leaving the method early).

Depends on #10563
Closes #10540

[petebacondarwin]

I think I agree that we should just log inside rethrow, since it won't do any harm and adding yet another config level seems unattractive and unnecessary.

[DavidSouther]

I think I agree

:) I'll redo it that way!

[petebacondarwin]

typo

[petebacondarwin]

@DavidSouther - thanks for this.
This looks good. I will fix the typo when merging.
The commit message needs just a tiny bit of tweaking:

• No uppercase letter at the start of the description
• No full stop at the end of the first line

which I will also fix when merging

[DavidSouther]

@petebacondarwin The branch is closed - did you want me to fix the commit message, typo, and ask for reopen?

[petebacondarwin]

I merged it into 1.3.x and 1.4.x already

[petebacondarwin]

I closed the PR by mentioning it in the commit that landed in master

[DavidSouther]

Gotcha! I see where the merge happened; I'm just so used to seeing the
purple Github "merged" icon :) Thanks for your help, and thanks for taking
this change!

On Tue Dec 23 2014 at 2:25:56 PM Pete Bacon Darwin notifications@github.com
wrote:

I closed the PR by mentioning it in the commit that landed in master

—
Reply to this email directly or view it on GitHub
#10564 (comment).

[petebacondarwin]

Yes, in Angular we don't use GitHub's merge as we rather have a linear git history.
We always rebase and do fast forward merges only (and cherry pick to other version branches).
By adding the "Closes #XXX" phrase to the bottom of the commit we can trigger Github to automatically close the PR. Perhaps we should ask them to support a "Merges #XXX" tag too?