This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($exceptionHandlerProvider): call inject() to run tests
#10563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2014
In the current angular-mocksSpec, the tests for $exceptionHandlerProvider call `module` to run tests on `$exceptionHandlerProvider.mode()`, but do not call `inject()` to pump the module definitions.
| @@ -592,22 +592,29 @@ describe('ngMock', function() { | |||
| })); | |||
|
|
|||
|
|
|||
| it('should log exceptions', module(function($exceptionHandlerProvider) { | |||
| $exceptionHandlerProvider.mode('log'); | |||
| var $exceptionHandler = $exceptionHandlerProvider.$get(); | |||
There was a problem hiding this comment.
Isn't this call to $get enough here?
There was a problem hiding this comment.
No, because the code in the module() block does not get executed. I have a branch that verifies the (lack of) executing code using console.log.
There was a problem hiding this comment.
OK. Great. Let's get this merged.
|
I'm not sure why Travis failed - https://travis-ci.org/angular/angular.js/builds/44946893 - I don't think that's my fault? |
|
Travis is flaky. I landed this. Thanks! |
petebacondarwin
pushed a commit
that referenced
this pull request
Dec 23, 2014
In the current angular-mocksSpec, the tests for $exceptionHandlerProvider call `module` to run tests on `$exceptionHandlerProvider.mode()`, but do not call `inject()` to pump the module definitions. Closes #10563
petebacondarwin
pushed a commit
that referenced
this pull request
Dec 23, 2014
In the current angular-mocksSpec, the tests for $exceptionHandlerProvider call `module` to run tests on `$exceptionHandlerProvider.mode()`, but do not call `inject()` to pump the module definitions. Closes #10563
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current angular-mocksSpec, the tests for $exceptionHandlerProvider
call
moduleto run tests on$exceptionHandlerProvider.mode(), but donot call
inject()to pump the module definitions.