Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

When we click Ctrl+"Edit in Plunker" button, the Plunker is not opening in new tab. #10641

Closed
rajeshwarpatlolla opened this issue Jan 5, 2015 · 6 comments

Comments

@rajeshwarpatlolla
Copy link

When we click Ctrl+"Edit in Plunker" button, the plunker is not opening in new tab, instead it is opening the plunker in the same tab. But when we click Ctrl+edit in plunker button, it should open in the new tab, which is not happening as of now. And because of it we are unable to stay in the same page to refer the docs.

@arpit2438735
Copy link

It's very specific to Browser.It's not a issue with Angular website,can you retest the same scenario with different site probably Stackoverflow

@rajeshwarpatlolla
Copy link
Author

When i click Ctrl+"Edit in Plunker" in "angular-ui.github.io/bootstrap/", the plunker is opening in a new tab. But this is not happenning in "angularjs.org". In "angularjs.org", when i do the same the plunker is opening in the same tab.

@arpit2438735
Copy link

Ok that fine but this forum is not for website bug it is specific to angular.js code.You can post the bug to https://github.com/angular/angularjs.org

@pkozlowski-opensource
Copy link
Member

Closing as duplicate of angular/angularjs.org#149

@jeffbcross
Copy link
Contributor

Reopening, as the code for this is actually in angular.js, not angularjs.org: https://github.com/angular/angular.js/blob/master/docs/config/templates/runnableExample.template.html

@ghoti143
Copy link
Contributor

Looks like the plunkr form used to open in a new window, but due to popup blockers getting in the way the behavior was changed to it's current state.

925b208

Are there any other alternatives we can come up with? I suppose we could make the default behavior be same window, but if the Ctrl button is pressed, we can open with target="_blank".

@caitp caitp closed this as completed in dca5fa7 Jan 23, 2015
caitp pushed a commit that referenced this issue Jan 23, 2015
This change allows users to ctrl+click on the "Edit in Plunker"
button which will set the posted form's target attribute to
"_blank" instead of "_self" which is the default.

Closes #10641
Closes #10826
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants