This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial suggestion for dealing with the problem described in #10641. To summarize, the problem is:
openPlunkr
function is fired on click which callsformPostData
formPostData
creates a new form element, adds it to the page, posts it, and removes the form elementtarget="_self"
)"_blank"
, however, can trigger the popup blocker.To resolve, the following steps were taken:
$event
object into theopenPlunkr
functiontarget="_blank"
target="_self"
This enables a user to "opt-in" to the new window functionality, and the assumption is that they will whitelist the AngularJS docs page so their popup blocker doesn't block the popup. However, for the users who do not ctrl+click, they will continue experiencing the default functionality and not experience the undesired behavior described above.