Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ngIf on body stop animation #12366

Closed
ricardobfa opened this issue Jul 16, 2015 · 4 comments
Closed

ngIf on body stop animation #12366

ricardobfa opened this issue Jul 16, 2015 · 4 comments

Comments

@ricardobfa
Copy link

When i use a condition (in my case ngIf) in the body, all animation using ngAnimate dos not work anymore.

reproduced:
http://codepen.io/anon/pen/MwByOL

I tried using a old version (1.3.15) and everything back to normal.

@matsko
Copy link
Contributor

matsko commented Jul 17, 2015

It seems like Angular Material is having an issue with the latest release of 1.4. @ThomasBurleson and I are getting to the bottom of it.

@matsko
Copy link
Contributor

matsko commented Aug 25, 2015

@ricardobfa this looks like it's still not working with the latest patch we have for ngAnimate. Once #12669 is in then I'll be able to figure this one out. Sorry for the delay.

matsko added a commit to matsko/angular.js that referenced this issue Aug 31, 2015
If an ngIf is placed on the body then resulting node is different from
what was there originally and that causes issues with ngAnimate. This
patch fixes this.

Closes angular#12366
@matsko
Copy link
Contributor

matsko commented Aug 31, 2015

Alright we have a fix: http://www.angular-dev.com/pr-12366/index.html

This PR does the job: #12721

matsko added a commit to matsko/angular.js that referenced this issue Aug 31, 2015
If an ngIf is placed on the body then resulting node is different from
what was there originally and that causes issues with ngAnimate. This
patch fixes this.

Closes angular#12366
Closes angular#12721
@Narretz
Copy link
Contributor

Narretz commented Sep 24, 2015

This is fixed and will be part of the next 1.4 release.

@Narretz Narretz closed this as completed Sep 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants