This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAnimate): allow animations if the body node is changed #12721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an ngIf is placed on the body then resulting node is different from what was there originally and that causes issues with ngAnimate. This patch fixes this. Closes angular#12366 Closes angular#12721
|
The fix LGTM but really it should have some kind of test... |
|
This is closed. We got rid of the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an ngIf is placed on the body then resulting node is different from
what was there originally and that causes issues with ngAnimate. This
patch fixes this.
Closes #12366