Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

(bug) ngAnimate element.parent is not a function for empty jqLite collection #14558

Closed
maksimr opened this issue May 4, 2016 · 4 comments
Closed

(bug) ngAnimate element.parent is not a function for empty jqLite collection #14558

maksimr opened this issue May 4, 2016 · 4 comments
Labels
component: ngAnimate frequency: low severity: broken expected use type: bug

Comments

@maksimr
Copy link
Contributor

maksimr commented May 4, 2016

angular@1.5.5
angular-animate@1.5.5
angular-gettext@2.2.1

Use case which reproduce the problem:

http://jsbin.com/zaviju/edit?html,js,output

<!DOCTYPE html>
<html>
<head>
<meta name="description" content="[add your bin description]">
  <meta charset="utf-8">
  <meta name="viewport" content="width=device-width">
  <title>JS Bin</title>

<script src="https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.5.5/angular.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.5.5/angular-animate.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/angular-gettext/2.2.1/angular-gettext.js"></script>
</head>



<body ng-app="app">

<span translate="">
</span>

<script>
   angular.module('app', ['ngAnimate','gettext']);
</script>
</body>
</html>

ER: No javascript exception
AR:

runner-3.35.12.min.js:1 TypeError: element.parent is not a function
    at queueAnimation (https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.5.5/angular-animate.js:2461:26)
    at Object.$animate.push (https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.5.5/angular-animate.js:2411:16)
    at Object.enter (https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.5.5/angular.js:5398:31)
    at update (https://cdnjs.cloudflare.com/ajax/libs/angular-gettext/2.2.1/angular-gettext.js:447:34)
    at post (https://cdnjs.cloudflare.com/ajax/libs/angular-gettext/2.2.1/angular-gettext.js:463:21)
    at invokeLinkFn (https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.5.5/angular.js:9694:9)
    at nodeLinkFn (https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.5.5/angular.js:9093:11)
    at compositeLinkFn (https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.5.5/angular.js:8397:13)
    at compositeLinkFn (https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.5.5/angular.js:8400:13)
    at publicLinkFn (https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.5.5/angular.js:8277:30) <span translate="">

Related issues:
#11703
rubenv/angular-gettext#255
@maksimr maksimr mentioned this issue May 4, 2016
Closed
@gkalpak
Copy link
Member

gkalpak commented May 6, 2016

I am pretty sure this has been reported before, but I can't find the issue.
👍

@gkalpak gkalpak closed this as completed in 5b053b1 May 6, 2016
gkalpak pushed a commit that referenced this issue May 6, 2016
@maksimr @gkalpak
fix(ngAnimate): properly handle empty jqLite collections
fdaf4d5 
Previously `stripCommentsFromElement()` would return an empty Array (instead of a jqLite collection)
which would cause an exception to be thrown: "element.parent not a function".
This commit fixes it, by ensuring that the returned value is always a jqLite collection.

Closes #14558

Closes #14559
@maksimr
Copy link
Contributor Author

maksimr commented May 6, 2016

@gkalpak I have added related issues to my description :)
Issue #11703 has same error message but another reason

Thanks

@maksimr
Copy link
Contributor Author

maksimr commented May 8, 2016

@gkalpak when can we expect new version in npm?

@gkalpak
Copy link
Member

gkalpak commented May 13, 2016 •
edited
Loading

I am pretty sure this has been reported before, but I can't find the issue.

That's what I had in mind: 2aacc2d#commitcomment-17251606

when can we expect new version in npm?

Hopefully before the end of next week 😃

BTW, I hadn't preperly backported it to v1.5.x. Fixing it now...

gkalpak pushed a commit that referenced this issue May 13, 2016
@maksimr @gkalpak
fix(ngAnimate): properly handle empty jqLite collections
9f48025 
Previously `stripCommentsFromElement()` would return an empty Array (instead of a jqLite collection)
which would cause an exception to be thrown: "element.parent not a function".
This commit fixes it, by ensuring that the returned value is always a jqLite collection.

Closes #14558

Closes #14559
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: ngAnimate frequency: low severity: broken expected use type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ngAnimate): ensure animations are not attempted on empty jqLite c…
2 participants
@maksimr @gkalpak