optional `comparator` parameter in `$filter('filter')(array, expression, comparator, anyPropertyKey)` #15312

ranjan-2209 · 2016-10-25T09:50:28Z

In this website: https://docs.angularjs.org/api/ng/filter/filter, comparator parameter is optional in $filter('filter')(array, expression, comparator, anyPropertyKey)

The text was updated successfully, but these errors were encountered:

gkalpak · 2016-10-25T10:54:25Z

Listing undefined as one of the possible values is an unorthodox way of saying it is optional, I guess.
If someone wants to submit a PR to properly mark it as optional (and mention that it defaults to false), I would be happy to merge 😄

ranjan-2209 · 2016-10-25T14:35:02Z

Also, default value is false.

gkalpak · 2016-10-25T17:11:49Z

That's what I said 😃

…parator parameter change the documentation for $filter so that the comparator parameter is marked optional. Also specified that the default value is false. Closes angular#15312

kylewuolle · 2016-11-06T18:47:36Z

I submitted a PR 15371 for this!

Mark the `comparator` parameter as optional and mention that it defaults to `false`. Fixes #15312 Closes #15371

ranjan-2209 · 2016-11-07T13:55:30Z

this isn't showing in docs?

Mark the `comparator` parameter as optional and mention that it defaults to `false`. Fixes angular#15312 Closes angular#15371

Mark the `comparator` parameter as optional and mention that it defaults to `false`. Fixes #15312 Closes #15371

Mark the `comparator` parameter as optional and mention that it defaults to `false`. Fixes angular#15312 Closes angular#15371

gkalpak added this to the Backlog milestone Oct 25, 2016

gkalpak added type: docs PRs plz! component: filters labels Oct 25, 2016

kylewuolle mentioned this issue Nov 6, 2016

fix($filter): change documentation of $filter to reflect optional com… #15371

Closed

gkalpak closed this as completed in b5a5623 Nov 7, 2016

gkalpak pushed a commit that referenced this issue Nov 7, 2016

docs(filterFilter): mark the comparator parameter as optional

d675b62

Mark the `comparator` parameter as optional and mention that it defaults to `false`. Fixes #15312 Closes #15371

petebacondarwin pushed a commit that referenced this issue Nov 23, 2016

docs(filterFilter): mark the comparator parameter as optional

9270cc4

Mark the `comparator` parameter as optional and mention that it defaults to `false`. Fixes #15312 Closes #15371

petebacondarwin pushed a commit that referenced this issue Nov 24, 2016

docs(filterFilter): mark the comparator parameter as optional

5b0e4ca

Mark the `comparator` parameter as optional and mention that it defaults to `false`. Fixes #15312 Closes #15371

ellimist pushed a commit to ellimist/angular.js that referenced this issue Mar 15, 2017

docs(filterFilter): mark the comparator parameter as optional

cef59c7

Mark the `comparator` parameter as optional and mention that it defaults to `false`. Fixes angular#15312 Closes angular#15371

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

optional `comparator` parameter in `$filter('filter')(array, expression, comparator, anyPropertyKey)` #15312

optional `comparator` parameter in `$filter('filter')(array, expression, comparator, anyPropertyKey)` #15312

ranjan-2209 commented Oct 25, 2016

gkalpak commented Oct 25, 2016

ranjan-2209 commented Oct 25, 2016

gkalpak commented Oct 25, 2016

kylewuolle commented Nov 6, 2016

ranjan-2209 commented Nov 7, 2016

optional comparator parameter in $filter('filter')(array, expression, comparator, anyPropertyKey) #15312

optional comparator parameter in $filter('filter')(array, expression, comparator, anyPropertyKey) #15312

Comments

ranjan-2209 commented Oct 25, 2016

gkalpak commented Oct 25, 2016

ranjan-2209 commented Oct 25, 2016

gkalpak commented Oct 25, 2016

kylewuolle commented Nov 6, 2016

ranjan-2209 commented Nov 7, 2016

optional `comparator` parameter in `$filter('filter')(array, expression, comparator, anyPropertyKey)` #15312

optional `comparator` parameter in `$filter('filter')(array, expression, comparator, anyPropertyKey)` #15312