-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix($filter): change documentation of $filter to reflect optional com… #15371
Conversation
…parator parameter change the documentation for $filter so that the comparator parameter is marked optional. Also specified that the default value is false. Closes angular#15312
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
Mark the `comparator` parameter as optional and mention that it defaults to `false`. Fixes angular#15312 Closes angular#15371
Mark the `comparator` parameter as optional and mention that it defaults to `false`. Fixes angular#15312 Closes angular#15371
Mark the `comparator` parameter as optional and mention that it defaults to `false`. Fixes angular#15312 Closes angular#15371
Mark the `comparator` parameter as optional and mention that it defaults to `false`. Fixes angular#15312 Closes angular#15371
Mark the `comparator` parameter as optional and mention that it defaults to `false`. Fixes angular#15312 Closes angular#15371
Mark the `comparator` parameter as optional and mention that it defaults to `false`. Fixes angular#15312 Closes angular#15371
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
documentation update
What is the current behavior? (You can also link to an open issue here)
In the $filter documentation the comparator parameter is not identified as being optional. See issue [15312] (#15312).
What is the new behavior (if this is a feature change)?
In the documentation for $filter the comparator parameter is now marked optional and the default value is identified as being false.
Does this PR introduce a breaking change?
No
Other information:
change the documentation for $filter so that the comparator parameter is marked optional. Also specified that the default value is false.
Closes #15312