Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($filter): change documentation of $filter to reflect optional com… #15371

Closed
wants to merge 1 commit into from

Conversation

kylewuolle
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
documentation update

What is the current behavior? (You can also link to an open issue here)
In the $filter documentation the comparator parameter is not identified as being optional. See issue [15312] (#15312).

What is the new behavior (if this is a feature change)?
In the documentation for $filter the comparator parameter is now marked optional and the default value is identified as being false.

Does this PR introduce a breaking change?
No

Other information:

change the documentation for $filter so that the comparator parameter is marked optional. Also specified that the default value is false.

Closes #15312

…parator parameter

change the documentation for $filter so that the comparator parameter is marked optional. Also specified that the default value is false.

Closes angular#15312
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@kylewuolle
Copy link
Contributor Author

I signed it

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Nov 6, 2016
@gkalpak gkalpak closed this in b5a5623 Nov 7, 2016
gkalpak pushed a commit that referenced this pull request Nov 7, 2016
Mark the `comparator` parameter as optional and mention that it defaults to `false`.

Fixes #15312

Closes #15371
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
Mark the `comparator` parameter as optional and mention that it defaults to `false`.

Fixes angular#15312

Closes angular#15371
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
Mark the `comparator` parameter as optional and mention that it defaults to `false`.

Fixes angular#15312

Closes angular#15371
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
Mark the `comparator` parameter as optional and mention that it defaults to `false`.

Fixes angular#15312

Closes angular#15371
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
Mark the `comparator` parameter as optional and mention that it defaults to `false`.

Fixes angular#15312

Closes angular#15371
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
Mark the `comparator` parameter as optional and mention that it defaults to `false`.

Fixes angular#15312

Closes angular#15371
petebacondarwin pushed a commit that referenced this pull request Nov 23, 2016
Mark the `comparator` parameter as optional and mention that it defaults to `false`.

Fixes #15312

Closes #15371
petebacondarwin pushed a commit that referenced this pull request Nov 24, 2016
Mark the `comparator` parameter as optional and mention that it defaults to `false`.

Fixes #15312

Closes #15371
ellimist pushed a commit to ellimist/angular.js that referenced this pull request Mar 15, 2017
Mark the `comparator` parameter as optional and mention that it defaults to `false`.

Fixes angular#15312

Closes angular#15371
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optional comparator parameter in $filter('filter')(array, expression, comparator, anyPropertyKey)
2 participants