Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Add e2e tests for $anchorScroll #9535

Closed
gkalpak opened this issue Oct 10, 2014 · 2 comments
Closed

Add e2e tests for $anchorScroll #9535

gkalpak opened this issue Oct 10, 2014 · 2 comments

Comments

@gkalpak
Copy link
Member

gkalpak commented Oct 10, 2014

It would make sense to have some e2e tests for $anchorScroll in order to test the actual scrolling (especially in regard to the yOffset functonality - once #9517 lands).

Since putting these in the docs app is a little too much, we should add the tests as soon as #9527 gets implemented.

/ping @petebacondarwin , @tbosch

@tbosch tbosch self-assigned this Oct 10, 2014
@tbosch tbosch added this to the Backlog milestone Oct 10, 2014
@tbosch tbosch removed their assignment Oct 10, 2014
@gkalpak
Copy link
Member Author

gkalpak commented Oct 13, 2014

In the meantime I have added some e2e tests in the docs app (#9583).
There still is functionality that needs to be tested, but it's a start.


My concern is whether the tests' complexity might scare people away !
Either because one has to interact with the window and the DOM (via async lower-level WebDriver APIs) or because I am missing a more straightforward way to write them, the tests look quite more complex that "usual" protractor tests.
Insights welcome :)

/cc @petebacondarwin

@tbosch
Copy link
Contributor

tbosch commented Oct 13, 2014

Note: The syntax for this tests could be made simpler if we added some helper methods and matchers for testing animations in general (e.g. expect a movement from a to b, ...).

gkalpak added a commit to gkalpak/angular.js that referenced this issue Jul 18, 2016
gkalpak added a commit to gkalpak/angular.js that referenced this issue Jul 19, 2016
gkalpak added a commit to gkalpak/angular.js that referenced this issue Jul 19, 2016
gkalpak added a commit to gkalpak/angular.js that referenced this issue Jul 19, 2016
gkalpak added a commit that referenced this issue Jul 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants