This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Add e2e tests for $anchorScroll #9535
Labels
Milestone
Comments
In the meantime I have added some e2e tests in the docs app (#9583). My concern is whether the tests' complexity might scare people away ! /cc @petebacondarwin |
Note: The syntax for this tests could be made simpler if we added some helper methods and matchers for testing animations in general (e.g. expect a movement from a to b, ...). |
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this issue
Jul 18, 2016
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this issue
Jul 19, 2016
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this issue
Jul 19, 2016
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this issue
Jul 19, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It would make sense to have some e2e tests for $anchorScroll in order to test the actual scrolling (especially in regard to the
yOffset
functonality - once #9517 lands).Since putting these in the docs app is a little too much, we should add the tests as soon as #9527 gets implemented.
/ping @petebacondarwin , @tbosch
The text was updated successfully, but these errors were encountered: