fix(orderBy): maintain order in array of objects when predicate is not provided #10311
Conversation
…t provided In ES262, there are two properties which are used to get a primitive value from an Object: - valueOf() -- a method which returns a primitive value represented by the Object - toString() -- a method which returns a string value representing the Object. When comparing objects using relational operators, the abstract operation ToPrimitive(O, TypeHint) is used, which will use these methods to retrieve a value. This CL emulates the behaviour of ToPrimitive(), and ensures that no ordering occurs if the retrieved value is identical. This behaviour was previously used for Date objects, however it can be safely made generic as it applies to all objects. Closes angular#9566 Closes angular#9747
|
CLAs look good, thanks! |
|
The reason I prefer this to the other PRs is, I don't think we want to implicitly switch to "reverse" sorting mode, that doesn't make any sense --- and we also don't want to special-case objects outside of the comparator function. The reasons why it results in array reversal has to do with the comparison between So for instance, The algorithm will thus reverse the two items. But really we should be returning 0 here to not reverse them. It also generalizes a behaviour which was already in the code. |
|
@lgalfaso / @gkalpak / @petebacondarwin comments? lets land one. |
|
OK! I like this one. LGTM |
|
Did we backport this fix to 1.2.x? The cause of the bug is in 1.2, too: 45b896a |
|
It was not back ported |
|
Yes, there was an issue: #10488 Now closed, because an update to 1.3 fixed the issue. |
|
My impression is that the issue was not really needing it for 1.2 - since this would create a minor breaking change I would prefer not to backport unless people start requesting it. |
In ES262, there are two properties which are used to get a primitive value from an Object:
When comparing objects using relational operators, the abstract operation ToPrimitive(O, TypeHint) is used,
which will use these methods to retrieve a value.
This CL emulates the behaviour of ToPrimitive(), and ensures that no ordering occurs if the retrieved value
is identical.
This behaviour was previously used for Date objects, however it can be safely made generic as it applies to
all objects.
Closes #9566
Closes #9747