fix(orderBy): Mantain order in array of objects when predicate is not provided #9747
Conversation
| @@ -91,6 +91,23 @@ describe('Filter: orderBy', function() { | |||
| .toEqualData([{"원": 31000}, {"원": 76000}, {"원": 156000}]); | |||
| }); | |||
|
|
|||
| it('should maintain order in an array of objects when no predicate is provided', function(){ | |||
|
LGTM with nits |
| @@ -130,6 +131,12 @@ function orderByFilter($parse){ | |||
| } | |||
| if (predicate === '') { | |||
| // Effectively no predicate was passed so we compare identity | |||
| if (array.some(angular.isObject)) { | |||
There was a problem hiding this comment.
This should just be isObject similar to isArray above...
|
@juangabreil you there? it needs a rebase and @jbedard / @gkalpak 's nits look right to me --- other than that I think it can land |
|
So get that done and ping me alright? =) |
juangabreil
force-pushed
the
issue-9566
branch
from
ac2e631 to
1a3c218
Compare
|
Hi! Sorry I'm not at home this week and my Internet access is very limited. I've fixed all the nits and made a rebase. It's my first rebase, if there is any problem, please tell me. |
# The first commit's message is: fix(orderBy): Mantain order in array of objects when predicate is not provided. # This is the 2nd commit message: style(*): Fix nits. # This is the 3rd commit message: fix(*): solve function nit.
juangabreil
force-pushed
the
issue-9566
branch
from
1a3c218 to
2afc31a
Compare
|
Actually, I did it wrong 😁 I forgot to get latest from master. I made it again, and it seems to be ok. Anyway, if there is something wrong, please tell me. |
|
honestly I have no idea. |
|
So this is still a bug http://plnkr.co/edit/0tnokZMrgNgDtmnFo8uQ?p=preview --- I think we should land one of these fixes. @Narretz which one do you like better? |
|
I don't really feel like either one is correct, I'll try submitting something |
…t provided In ES262, there are two properties which are used to get a primitive value from an Object: - valueOf() -- a method which returns a primitive value represented by the Object - toString() -- a method which returns a string value representing the Object. When comparing objects using relational operators, the abstract operation ToPrimitive(O, TypeHint) is used, which will use these methods to retrieve a value. This CL emulates the behaviour of ToPrimitive(), and ensures that no ordering occurs if the retrieved value is identical. This behaviour was previously used for Date objects, however it can be safely made generic as it applies to all objects. Closes angular#9566 Closes angular#9747
Fixes #9566