This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): respect return value from controller constructor #10502
+545
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new/isolate scopes
bindToController is now able to be specified as a convenient object notation:
```
bindToController: {
text: '@text',
obj: '=obj',
expr: '&expr'
},
scope: {}
```
It can also be used in conjunction with new scopes, rather than exclusively isolate scopes:
```
bindToController: {
text: '@text',
obj: '=obj',
expr: '&expr'
},
scope: true
```
Closes angular#10420
|
CLAs look good, thanks! |
The return value of the controller constructor is now respected in all cases. If controllerAs is used, the controller will be re-bound to scope. If bindToController is used, the previous binding $watches (if any) will be unwatched, and bindings re-installed on the new controller.
| // If result changed, re-assign controllerAs value to scope. | ||
| addIdentifier(locals, identifier, instance, constructor || expression.name); | ||
| } | ||
| } | ||
| return instance; | ||
| }, { | ||
| instance: instance, |
There was a problem hiding this comment.
Wouldn't we need this instance to also be updated, if result !== instance ?
(Could this by why you defined instantiate as a variable, but then forgot to update it's instance property ?)
There was a problem hiding this comment.
We need it to not be updated so the controller knows to update bindings. But it is true that instantiate isn't needed anymore
|
Version of this landed in 62d514b already |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return value of the controller constructor is now respected in all cases.
If controllerAs is used, the controller will be re-bound to scope. If bindToController is used, the previous binding $watches (if any) will be unwatched, and bindings re-installed on the new controller.
Blocked on #10467 --- This potentially results in leaks and performance regressions, good review is needed here.