This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAria): correctly set "checked" attr for checkboxes and radios #11007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -85,6 +85,28 @@ describe('$aria', function() { | |||
| expect(element.attr('aria-checked')).toBe('false'); | |||
| }); | |||
|
|
|||
| it('should handle checkbox with string model values using ng(True|False)Value', function() { | |||
| var element = $compile('<input type="checkbox" ng-model="val" ng-true-value="\'yes\'">' + | |||
| 'ng-false-value="\'no\'"' | |||
There was a problem hiding this comment.
Should this attribute be part of the input element?
There was a problem hiding this comment.
Yes, definitely! although it doesn't make a difference, since we don't test if the correct ng-false-value is set.
Make sure the checked attribute is set correctly for: - checkboxes with string and integer models using ngTrueValue / ngFalseValue - radios with integer models - radios with boolean models using ngValue Fixes angular#10389 Fixes angular#10212
|
This looks good to me. Nice work on the test coverage! 👍 (the ci failures look unrelated to your changes) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the checked attribute is set correctly for:
ngFalseValue
Fixes #10389
Fixes #10212
@marcysutton can you take a look at this?