docs(guide/Unit Testing): fixing the example for testing fiflter. #11410
Conversation
Hi there, It seems that in the example which starts at line 256 there need to be an injection for $filter as in the previous example.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
| it('returns 0 when given null', function() { | ||
| var length = $filter('length'); | ||
| expect(length(null)).toEqual(0); | ||
| }); | ||
|
|
||
| it('returns the correct value when given a string of chars', function() { | ||
| beforeEach(inject(function(_$filter_){ |
There was a problem hiding this comment.
The second beforeEach should not be needed - beforeEachh is applied to every it inside it.
There was a problem hiding this comment.
The first one is fine then?
There was a problem hiding this comment.
Great. Happy to help.
|
One more thing before we can merge: Can you please sign the CLA? |
|
Sure, On Wed, Mar 25, 2015 at 8:02 PM, Martin Staffa notifications@github.com
|
|
CLAs look good, thanks! |
|
I thing I have already signed it. On Wed, Mar 25, 2015 at 8:10 PM, gonen jerbi gonengar@gmail.com wrote:
|
|
Sure. CLAs look good, thanks! — |
Hi there, It seems that in the example which starts at line 256 there needs to be an injection for $filter as in the previous example. Closes #11410
Hi there, It seems that in the example which starts at line 256 there needs to be an injection for $filter as in the previous example. Closes angular#11410
Hi there,
It seems that in the example which starts at line 256 there need to be an injection for $filter as in the previous example.