Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/Unit Testing): fixing the example for testing fiflter. #11410

Closed
wants to merge 1 commit into from
Closed

docs(guide/Unit Testing): fixing the example for testing fiflter. #11410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/content/guide/unit-testing.ngdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,12 +260,20 @@ myModule.filter('length', function() {
});

describe('length filter', function() {

beforeEach(inject(function(_$filter_){
$filter= _$filter_;
}));

it('returns 0 when given null', function() {
var length = $filter('length');
expect(length(null)).toEqual(0);
});

it('returns the correct value when given a string of chars', function() {
beforeEach(inject(function(_$filter_){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second beforeEach should not be needed - beforeEachh is applied to every it inside it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first one is fine then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YEp!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Happy to help.

$filter= _$filter_;
}));
var length = $filter('length');
expect(length('abc')).toEqual(3);
});
Expand Down