Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

stop coercing falsy values to null before xhr.send() #11567

Closed
wants to merge 2 commits into from

Conversation

johnhoffman
Copy link
Contributor

This is intended to resolve #11552.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@johnhoffman
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@johnhoffman
Copy link
Contributor Author

I authored the commits.

@samjacobclift
Copy link

I've had a little play with this issue. I've created a test I think is valid to check the behaviour.

see: samjacobclift@89ec5af

@pkozlowski-opensource
Copy link
Member

@johnhoffman your commit is missing tests so we can't merge it as-is. There also seems to be an issue with the CLA - I suspect you've used a different e-mail / GitHub user name to author the commit and different one to sign the CLA.

@royka would you mind opening a PR with your change to see if the existing test pass? For example - do we need to convert undefined to null?

@samjacobclift
Copy link

@pkozlowski-opensource see here #11579

unit tests pass, seems that the e2e don't pass though :(

@googlebot
Copy link

CLAs look good, thanks!

@johnhoffman
Copy link
Contributor Author

I fixed the CLA and updated the PR. Still unable to build angular and run tests on my machine (https://docs.angularjs.org/misc/contribute) so I guess we resort to Travis CI?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$httpBackend coersion of falsy values to null before xhr.send()
4 participants