-
Notifications
You must be signed in to change notification settings - Fork 27.4k
stop coercing falsy values to null before xhr.send() #11567
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
I authored the commits. |
I've had a little play with this issue. I've created a test I think is valid to check the behaviour. |
@johnhoffman your commit is missing tests so we can't merge it as-is. There also seems to be an issue with the CLA - I suspect you've used a different e-mail / GitHub user name to author the commit and different one to sign the CLA. @royka would you mind opening a PR with your change to see if the existing test pass? For example - do we need to convert |
@pkozlowski-opensource see here #11579 unit tests pass, seems that the e2e don't pass though :( |
CLAs look good, thanks! |
I fixed the CLA and updated the PR. Still unable to build angular and run tests on my machine (https://docs.angularjs.org/misc/contribute) so I guess we resort to Travis CI? |
This is intended to resolve #11552.