This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($http): stop $httpBackend coersion of falsy values to null before xh... #11579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… xhr.send() stop $httpBackend from potentially overriding false values to null when sending a falsy value to a web service via POST or PUT et al
|
This passed: #11593. Apparently, the E2E tests can fail for extraneous reasons. |
|
Just to be clear, it is (almost) always possible to say if the test failures are flakes or real failures by looking at the Travis job logs. For the record, the test failures for this commit are real, but unrelated to this fix. Closing this in favor of #11593 (which has better test coverage). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...r.send()
stop $httpBackend from potentially overriding false values to null when sending a falsy value to a web service via POST or PUT et al