This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngModel): form validation and Object.prototype enumerable values #12075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rable value When adding an Object.prototype enumerable property, this should not be confused as a form error Closes angular#12066
| expect(formCtrl.$invalid).toBe(false); | ||
| delete Object.prototype.someThing; | ||
|
|
||
| dealoc(element); |
There was a problem hiding this comment.
and in practice, generates the error "Error: Found jqCache references that were not deallocated! count: 1"
Keep in mind that this is a new element (not the global one)
There was a problem hiding this comment.
Right !
Why not reuse the global element then ? :)
There was a problem hiding this comment.
The global element is already compiled with a content that is not good for this test. This same thing is done for other tests in the same file.
There was a problem hiding this comment.
I should have taken a more detailed look :)
(Sorry for the noise...)
|
landed as 0934b76 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding an Object.prototype enumerable property, this should not be confused
as a form error
Closes #12066