This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAnimate): buffer repeated calls to RAF to improve performance for animations #12347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsko
force-pushed
the
intelligent_raffing
branch
from
1cc6317 to
6dcca5a
Compare
…or animations Prior to this patch ngAnimate buffered all repeated calls to requestAnimationFrame into a task queue that is flushed once the next animation frame has passed. While this works it causes a random lag to jump out when any CPU intensive rAF requests are processed. This patch sets a configurable task range which then offsets followup rAF requests into the next available frame. Closes angular#12280
matsko
force-pushed
the
intelligent_raffing
branch
from
6dcca5a to
56fe8db
Compare
|
LGTM The implementation seems unnecessarily complex imo. I don't have proof though and since I can't spot any functional issue/bug (e.g. as was the case with the previous implementation), I'll leave it to the LGTM 😄 |
|
Closed in favour of: #12619 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch ngAnimate buffered all repeated calls to
requestAnimationFrame into a task queue that is flushed once the next
animation frame has passed. While this works it causes a random lag to
jump out when any CPU intensive rAF requests are processed. This patch
sets a configurable task range which then offsets followup rAF requests
into the next available frame.
Closes #12280