fix(ngAria): Apply ARIA attrs correctly #13483
Conversation
|
Well done @marcysutton - thanks. We will get this in after 1.5.0 is released |
marcysutton
force-pushed
the
ngaria-aria-attr-fixes
branch
from
709b79c to
82c6438
Compare
marcysutton
force-pushed
the
ngaria-aria-attr-fixes
branch
from
82c6438 to
de718c8
Compare
There was a problem hiding this comment.
These links should be {@link ng/directive/ngValue} and {@link ng/directive/ngChecked}.
marcysutton
force-pushed
the
ngaria-aria-attr-fixes
branch
from
de718c8 to
9af2245
Compare
There was a problem hiding this comment.
I'm not sure if ng/directive/ngrequired (instead of ng/directive/ngRequired) works.
BREAKING CHANGE: Where appropriate, ngAria now applies ARIA to custom controls only, not native inputs. Because of this, support for `aria-multiline` on textareas has been removed. New support added for ngValue, ngChecked, and ngRequired, along with updated documentation. Closes angular#13078 Closes angular#11374 Closes angular#11830
marcysutton
force-pushed
the
ngaria-aria-attr-fixes
branch
from
9af2245 to
86e49e1
Compare
|
LGTM (the whitespace can be taken care of upon merging) |
|
@marcysutton, (a little too late) but I have some questions regarding dropping
|
| // if element does not have role attribute | ||
| // AND element type is equal to role (if custom element has a type equaling shape) <-- remove? | ||
| // AND element is not INPUT | ||
| return !elem.attr('role') && (elem.attr('type') === role) && (elem[0].nodeName !== 'INPUT'); |
There was a problem hiding this comment.
@marcysutton, why are we only checking against input ? Shouldn't all native controls (e.g. textarea, select, button) be excluded ?
There was a problem hiding this comment.
Yeah, that line should be replaced with isNodeOneOf(elem, nodeBlackList)). It has already gone through the getShape function but that only checks type and role.
4 participants
BREAKING CHANGE: Where appropriate, ngAria now applies ARIA to custom controls only, not native inputs. Because of this, support for
aria-multilineon textareas has been removed.New support added for ngValue, ngChecked, and ngRequired, along with updated documentation. Also supports ngTrueValue and ngFalseValue as part of ngModel.
Closes #13078
Closes #11374
Closes #11830
cc @petebacondarwin (I got this done finally! 😄)