feat(ngAria): add support for ngReadonly #14140

m-amr · 2016-02-27T01:14:50Z

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feat
What is the current behavior? (You can also link to an open issue here)
feat(ngAria): add support for ngReadonly #14077
What is the new behavior (if this is a feature change)?
add support for ngReadonly
Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements
The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
Other information:

handle aria-readonly based on ng-readonly
fix #14077

gkalpak · 2016-02-28T17:04:18Z

test/ngAria/ariaSpec.js

+
+      scope.$apply('val = true');
+      expect(element.attr('aria-readonly')).toBe('true');
+


Nitpick: Redundant newline.

I have removed the Nitpick: Redundant newline.

gkalpak · 2016-02-28T17:11:41Z

The code LGTM. Thx for working on this 👍
There are some missing docs:

Mention ngReadonly in the full list of directives that interface with ngAria.
Mention ngReadonly in the accessibiity dection of the Dev Guide (file: docs/content/guide/accessibility.ngdoc). See fix(ngAria): Apply ARIA attrs correctly #13483 for an example.

handle aria-readonly based on ng-readonly feat angular#14077

m-amr · 2016-02-28T21:24:34Z

I have updated the documentation to include
1 - full list of directives that interface with ngAria.
2 - docs/content/guide/accessibility.ngdoc

Thanks for your feedback.

Narretz · 2016-03-30T12:14:29Z

@gkalpak can you give this another look / merge it? It LGTM

Closes #14140 Closes #14077

googlebot added the cla: yes label Feb 27, 2016

m-amr force-pushed the add_ariaReadonly branch 3 times, most recently from 1de0bee to 008fe0c Compare February 27, 2016 02:14

Narretz added type: feature component: ngAria labels Feb 27, 2016

Narretz added this to the 1.5.x milestone Feb 27, 2016

gkalpak reviewed Feb 28, 2016
View reviewed changes

gkalpak added frequency: low severity: inconvenient needs: docs labels Feb 28, 2016

feat(ngAria): add support for ngReadonly

265cb72

handle aria-readonly based on ng-readonly feat angular#14077

m-amr force-pushed the add_ariaReadonly branch from 008fe0c to 265cb72 Compare February 28, 2016 21:07

Narretz self-assigned this Apr 7, 2016

Narretz pushed a commit that referenced this pull request Apr 8, 2016

feat(ngAria): add support for aria-readonly based on ngReadonly

ec0baad

Closes #14140 Closes #14077

Narretz closed this in ae0a716 Apr 8, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ngAria): add support for ngReadonly #14140

feat(ngAria): add support for ngReadonly #14140

m-amr commented Feb 27, 2016

gkalpak Feb 28, 2016

m-amr Feb 28, 2016

gkalpak commented Feb 28, 2016

m-amr commented Feb 28, 2016

Narretz commented Mar 30, 2016


		scope.$apply('val = true');
		expect(element.attr('aria-readonly')).toBe('true');

feat(ngAria): add support for ngReadonly #14140

feat(ngAria): add support for ngReadonly #14140

Conversation

m-amr commented Feb 27, 2016

gkalpak Feb 28, 2016

Choose a reason for hiding this comment

m-amr Feb 28, 2016

Choose a reason for hiding this comment

gkalpak commented Feb 28, 2016

m-amr commented Feb 28, 2016

Narretz commented Mar 30, 2016