fix(ngAnimate): ensure animations are not attempted on empty jqLite c… #14559

maksimr · 2016-05-04T16:30:18Z

Without this fix animation throw a javascript exception
element.parent not a function when we pass empty jqLite collection.

Closes #14558

…ollection Without this fix animation throw a javascript exception `element.parent not a function` when we pass empty jqLite collection. Closes #14558

Previously `stripCommentsFromElement()` would return an empty Array (instead of a jqLite collection) which would cause an exception to be thrown: "element.parent not a function". This commit fixes it, by ensuring that the returned value is always a jqLite collection. Closes #14558 Closes #14559

fix(ngAnimate): ensure animations are not attempted on empty jqLite c…

bfb23af

…ollection Without this fix animation throw a javascript exception `element.parent not a function` when we pass empty jqLite collection. Closes #14558

googlebot added the cla: yes label May 4, 2016

gkalpak closed this in 5b053b1 May 6, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ngAnimate): ensure animations are not attempted on empty jqLite c… #14559

fix(ngAnimate): ensure animations are not attempted on empty jqLite c… #14559

maksimr commented May 4, 2016

fix(ngAnimate): ensure animations are not attempted on empty jqLite c… #14559

fix(ngAnimate): ensure animations are not attempted on empty jqLite c… #14559

Conversation

maksimr commented May 4, 2016