Added example to $anchorScroll documentation. #2932
Conversation
Per a request made by Peter Bacon Darwin here: http://www.benlesh.com/2013/02/angular-js-scrolling-to-element-by-id.html?showComment=1370941217879#c8718313084813008967 I've added an example of basic usage. If more detail is desired, please let me know.
|
This was my first time adding documentation in this format. I wasn't sure if I could add more than one example, so I just added the most basic scenario. |
I've removed the end-to-end testing from the example given as it was breaking the build. I'm not sure how to reference the window object inside of the scenario.
Here's what I removed:
<file name="scenario.js">
it('should scroll to the bottom', function() {
var win = element(window),
initialScrollTop = win.scrollTop();
element('#top').click();
var currentScrollTop = win.scrollTop(),
documentBottom = currentScrollTop + win.height(),
elemTop = element('#bottom').offset().top,
elemBottom = elemTop + element('bottom').height();
var isInView = (elemBottom <= documentBottom) && (elemTop >= currentScrollTop);
expect(initialScrollTop).toBeLessThan(currentScrollTop);
expect(isInView).toEqual(true);
});
</file>
|
Made some progress. |
|
Nice. Why is window not available in the scenario, but document.body is? Is it because it's running in a tool outside of a browser? |
PR Checklist (Docs-only fix)
|
|
Anyone got a way to e2e test this? |
|
Perhaps the |
|
I can't work out how to test this in e2e. If no one else has any ideas then I'll just merge the example as-is without an e2e test, since it does work in practice. |
|
We should merge this as-is. |
|
Checked it out this morning. It doesn't work and it looks crazy. I just submitted a pull request with fixes for that: #3890 |
|
Hi Ben. Very helpful, but in "Scrolling To An Element By ID", which scroll will be effected if we have many div, every div have a scroll in the scope of 'MainCtrl'. |
|
@thanhthang20 Well, this isn't really a place for Q/A... but to answer your question, it should scroll any divs it needs to scroll to get to the element in question, since it's calling |
|
@Blesh Thanks so much, You are very nice! |
|
It seems the anchorScroller() doesn't work with latest angularJS 1.2.0 and 1.2.1 either. Haven't you tried it yet? |
|
Am I the only one who gets no actual scrolling? The page just jumps, even in the Angular docs. |
Per a request made by Peter Bacon Darwin here: http://www.benlesh.com/2013/02/angular-js-scrolling-to-element-by-id.html?showComment=1370941217879#c8718313084813008967
I've added an example of basic usage. If more detail is desired, please let me know.