This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Example in live docs doesn't work due to typo, it's also ugly #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2013
|
Can you squash your commit and follow our commit message guidelines? |
ghost
assigned 
|
It is still not working in the generated docs. Works in plunker though. |
|
@btford : Absolutely. I guess I missed seeing commit message guidelines. I'm assuming you mean these guidelines? this is the first time I've seen them. My apologies. Didn't think to squash the commit either, it makes sense. I guess I'm just used to "bush league" Githubbery. |
docs($anchorScroll) add scroll area CSS styling docs($anchorScroll) change scroll area height to 350px
Fix an issue where the example was not working due to referencing the wrong controller in the html ng-controller attribute. The demo was also unsightly due to it being too long to look reasonable on the screen. Add overflow and height CSS styling to the containing element to clean it up.
Per a request made by Peter Bacon Darwin here: http://www.benlesh.com/2013/02/angular-js-scrolling-to-element-by-id.html?showComment=1370941217879#c8718313084813008967
Clear up confusion about module declaration when using manual bootstrap.
It was not clear what you could pass to specify modules to load in the `module` parameter of this function. The `modules` parameter takes an array. The main case is to provide a String, which is the name of a "predefined" angular module. The side cases are to provide a Function (or an annotated function in the form of an Array), which will be invoked by the injector as a run block. It is not possible to "define" new modules via this parameter. Closes #3692
I noticed angular was adding these css classes to elements and believe they should be listed in the documentation at this page. The ng-scope class is mentioned in the developer guide, hence the link there, and the ng-binding class is not mentioned anywhere else in the documentation or the guide that I found. Closes #3728
Add a summary describing the ignored underscore syntax sugar helper, with a simple use case example. Closes #3621
Change MainCtrl to ScrollCtrl in the ng-controller attribute in the view to fix issue where Demo was not working. Added styling to prevent demo from being too invasive for the user.
|
FFS... I stink at Git. I'm not at all sure how to squash my 3 commits into one. For whatever reason it's including all sorts of other commits now. I'm going to close this and try again. |
|
Submitted a new pull request that wasn't all junked up: #3898 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, the html was pointing at the wrong controller, and the unstyled container for the scroll looked ugly because it was too tall.
This should fix that.