-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs($anchorScroll) change example controller name to ScrollCtrl and add... #3898
Conversation
…add styling Changed controller name in example html to ScrollCtrl to match name in example js. Add styling to example html so scrollable area is not obtrusive to documentation page design.
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
Fix for issue: #3891 |
@Blesh - this fix doesn't work for me in the docs pages either. Can you build the docs and test? |
I have yet to ever be able to get any part of Angular to build. grunt package, grunt docs, grunt test:docs ... nothing really works, errors across the board. I get JVM errors when it hits the minify step, I get an error where it can't find a module ../../build/errors.json when I try to build the docs by themselves. The grunt process has a lot of steps, as I'm sure you're aware, and I'm not sure when I'll get time to step through all of it to figure out every error I'm getting. The best I can tell is that I've done something that is causing a bug in the documentation generation process. I've noticed that in other examples the generated docs script tags have ids like "script.js-0" but for some reason in my example it's "script.js". I'm not sure if that has anything to do with the problem, but it's one difference I've noticed. Unfortunately, until I can get Angular to build on my machine, I'm not really going to be able to debug the issue. |
Lots of people keep trying to fix this so I thought we should land this as-is, since the example is now correct, even if it doesn't run correctly as a demo in the docs. It works when edited in a Plunker. Will raise a separate issue about why it is not working in the docs. |
I figured as much. I haven't had time to mess with it. |
Changed controller name in example html to ScrollCtrl to match name in example js. Add styling to example html so scrollable area is not obtrusive to documentation page design. Closes angular#3898
Changed controller name in example html to ScrollCtrl to match name in example js. Add styling to example html so scrollable area is not obtrusive to documentation page design. Closes angular#3898
... styling
Changed controller name in example html to ScrollCtrl to match name in example js.
Add styling to example html so scrollable area is not obtrusive to documentation page design.