Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs($anchorScroll) change example controller name to ScrollCtrl and add... #3898

Closed
wants to merge 1 commit into from

Conversation

benlesh
Copy link
Contributor

@benlesh benlesh commented Sep 6, 2013

... styling

Changed controller name in example html to ScrollCtrl to match name in example js.

Add styling to example html so scrollable area is not obtrusive to documentation page design.

…add styling

Changed controller name in example html to ScrollCtrl to match name in example js.

Add styling to example html so scrollable area is not obtrusive to documentation page design.
@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@benlesh
Copy link
Contributor Author

benlesh commented Sep 6, 2013

Fix for issue: #3891

@petebacondarwin
Copy link
Contributor

@Blesh - this fix doesn't work for me in the docs pages either. Can you build the docs and test?

@ghost ghost assigned petebacondarwin Sep 6, 2013
@benlesh
Copy link
Contributor Author

benlesh commented Sep 8, 2013

I have yet to ever be able to get any part of Angular to build. grunt package, grunt docs, grunt test:docs ... nothing really works, errors across the board. I get JVM errors when it hits the minify step, I get an error where it can't find a module ../../build/errors.json when I try to build the docs by themselves. The grunt process has a lot of steps, as I'm sure you're aware, and I'm not sure when I'll get time to step through all of it to figure out every error I'm getting.

The best I can tell is that I've done something that is causing a bug in the documentation generation process. I've noticed that in other examples the generated docs script tags have ids like "script.js-0" but for some reason in my example it's "script.js". I'm not sure if that has anything to do with the problem, but it's one difference I've noticed.

Unfortunately, until I can get Angular to build on my machine, I'm not really going to be able to debug the issue.

@petebacondarwin
Copy link
Contributor

Lots of people keep trying to fix this so I thought we should land this as-is, since the example is now correct, even if it doesn't run correctly as a demo in the docs. It works when edited in a Plunker. Will raise a separate issue about why it is not working in the docs.

@benlesh
Copy link
Contributor Author

benlesh commented Oct 9, 2013

I figured as much. I haven't had time to mess with it.

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Changed controller name in example html to ScrollCtrl to match name in example js.
Add styling to example html so scrollable area is not obtrusive to documentation page design.

Closes angular#3898
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Changed controller name in example html to ScrollCtrl to match name in example js.
Add styling to example html so scrollable area is not obtrusive to documentation page design.

Closes angular#3898
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants