Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngRepeat): ngRepeat and ngInclude should be allowed on the same element #3609

Closed
wants to merge 1 commit into from

Conversation

jankuca
Copy link
Contributor

@jankuca jankuca commented Aug 15, 2013

Lowering the priority of ngRepeat from 1000 to 400 fixes the issue that popped up couple of times right after the 1.2.0rc1 release (#3584, #3581).

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@IgorMinar
Copy link
Contributor

this should have worked. @matsko do you know anything about this?

@vojtajina
Copy link
Contributor

As discussed in person, we can't do this fix - applying ng-include before ng-repeat. If the value of ng-include is different per row (eg. ng-include="item.template" ng-repeat="item in items"), it's not gonna work (all rows will be the same).

@jankuca
Copy link
Contributor Author

jankuca commented Aug 15, 2013

You are right. I changed my test and now it fails. I am going to investigate this a bit more.

@mhevery mhevery closed this Aug 15, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants