fix(ng-option): allow new line after _collection_

[esarbanis]

Changed the regular expression to allow new line after collection

Closes #4142

[mary-poppins]

Thanks for the PR!

• Contributor signed CLA now or in the past
  • If you just signed, leave a comment here with your real name
• PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[esarbanis]

I just signed the CLA under the name of Efthymios Sarmpanis.

[petebacondarwin]

You should probably update the comment above too.

[petebacondarwin]

Can you provide a unit test that demonstrates the problem you have fixed as well please?

[esarbanis]

I have altered the commit, updated the comment and added a test case.

[esarbanis]

@jamie-pate the $ is actually part of the current regex which denotes the "ends with".

The \s is the javascript's regex symbol for space and the \n is for new line. So what the [\s\n]* says is that you may have 0 or more of whatever is in the square brackets. Or else "after the expression you may or may not have some occurrences of space and/or new lines.

[jamie-pate]

While that all makes sense to me in separation, matching 'after the end' is
new to me. I always thought of the end as, well, the end. Fin, finito,
caput.
On 2013-10-10 4:02 AM, "Efthymis Sarbanis" notifications@github.com wrote:

@jamie-pate https://github.com/jamie-pate the $ is actually part of the
current regex which denotes the "ends with".

The \s is the javascript's regex symbol for space and the \n is for new
line. So what the [\s\n]* says is that you may have 0 or more of whatever
is in the square brackets. Or else "after the expression you may or may
not have some occurrences of space and/or new lines.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4167#issuecomment-26044532
.

[esarbanis]

@jamie-pate actually it's not exactly "the end", it's more like "ends with" :)

[jamie-pate]

I'd love to see a good reference that explains it.
http://www.regular-expressions.info/anchors.html says "$ matches right after the last character in the string" (except with the multiline switch)..
MDN says "Matches end of input." (with the same caveat)

every regex resource i've seen says similar :(

[esarbanis]

@jamie-pate actually MDN is clear: "For example, /t$/ does not match the t in eater, but does match it in eat". So basically is an "ends with" notation.

If you try [t$]* in eat eat it will match the t in the end of each eat and not just the last t of the sentence.

You could try things out here to get the hang of it.

[jamie-pate]

That is clear, in that it says exactly what i just quoted. "Matches end of input" (in this case, the last character of the string provided)

Also [t$]* matches 't' and literal '$' (inside [] special characters aren't special)

You could try things out here to get the hang of it. ;)