This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(input.email): add support for the multiple attribute #4233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| @@ -614,7 +616,7 @@ function emailInputType(scope, element, attr, ctrl, $sniffer, $browser) { | |||
| }; | |||
|
|
|||
| ctrl.$formatters.push(emailValidator); | |||
| ctrl.$parsers.push(emailValidator); | |||
| ctrl.$parsers.push(emailValidator ); | |||
There was a problem hiding this comment.
Remove this hunk please. Do the same with the whitespace changes in the file below.
|
I signed the CLA a long time ago. |
|
Did not know about ngList directive. Maby the multiple attribute should trigger same behavior as ngList instead ? |
|
Rebased agains current master. |
If present will allow for multiple email addresses, separated with comma (,)
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
|
Unfortunately, we never got around to review your PR. The good news is, we are moving towards a solution that can handle collections on the ngModel level. This time it's for real! ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If present will allow for multiple email addresses, separated with comma (,)