Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fix(input): make it work with ngList. #4295

Closed
wants to merge 1 commit into from
Closed

Fix(input): make it work with ngList. #4295

wants to merge 1 commit into from

Conversation

sudodoki
Copy link

@sudodoki sudodoki commented Oct 6, 2013

Tried to solve Issue #4185.
Right now I managed to pass all the email & url specs by introducing plain check for every email in value array (in case it's array) and regular check (if it's not).

Should we just add by-pass validator, so that either default regexp or that set by pattern attribute should be used? How will this affect dirty-check?

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@sudodoki
Copy link
Author

sudodoki commented Oct 6, 2013

Oleksandr Lapshyn

@sudodoki
Copy link
Author

sudodoki commented Oct 9, 2013

Updated PR.

@sudodoki
Copy link
Author

Updated PR with all test for both email and url directives - probably not that good of idea doing the same with number type, since ngList's description is 'Text input that converts between a delimited string and an array of strings.' and numbers are clearly not text, right?
I used Array#every see in compatibility table.

@sudodoki
Copy link
Author

Rebased it at current master - should be able to merge in case you decide to.

Validity for inputs are checked for single value using static regexp, which won't work with ngList directive on the input, since it's getting us an array of attributes.
@sudodoki
Copy link
Author

Actually fixed CI. Partially, as it appears to be. Should I switch to forEach, or should I introduce every() function?

@petebacondarwin
Copy link
Contributor

I guess we close this one in favour of #4549?

@jasonzhang2022
Copy link

This fix is not in the main branch!. It is removed somehow

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants