feature(ngEnabled): define ngEnabled directive as negation of ngDisabled

[cqr]

Provide a negated form of the ngDisabled directive as ngEnabled in
the same vein as the ngHide/ngShow pair. Allow for slightly clearer
templates by avoiding double negatives, as in:

<input ng-disabled='!(predicate1 && predicate2)'/>
<input ng-enabled='predicate1 && predicate2'/>

Closes #1252

[mary-poppins]

Thanks for the PR!

• Contributor signed CLA now or in the past
  • If you just signed, leave a comment here with your real name
• PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[cqr]

Name for the CLA: Chris Rhoden

[cqr]

just so we're clear, the failure here is "ERROR [launcher.sauce]: Can not start firefox on SauceLabs"

[IgorMinar]

Sorry @chrisrhoden, I'm going to close this as explained #1252 (comment)

Thanks for the work you put into this! I appreciate it, but I hope you understand that we can't accept every single feature. Apologies for mislabeling the original issues as "PRs welcome".

[cqr]

Hi @IgorMinar – I gave up on this many months ago, as evidenced by my comment on #1252 where I beg everyone to stop +1ing a dead horse.

I really wish someone had been involved in the interim. There are fewer than 40 open issues with that tag and a spot check on my part suggests this isn't isolated. #3941 has had no attention since last september. #4997 has been sitting since December.

The way that I read that tag, every issue on it should be getting looked at every week. If it's not something that warrants a quick pass every week, it probably shouldn't have that tag. If looking over any set of issues once a week is too onerous, then you should probably stop asking for pull requests actively.

I'll be straight up, this (along with my 2 other pull requests, which were also "scheduled" and then forgotten) has made me far less likely to contribute to Angular. There have been bugs that I have encountered that I have monkey patched away rather than try to bring them to the attention of the project stewards and usher them through.

This is a problem that I know you guys know you have, or have at least made public announcements of your intention to fix, but it's not clear to me that you understand what is frustrating about the situation. The fact that you would say, "I hope you understand that we can't accept every single feature," strongly suggests to me that you think that I am going to throw a temper tantrum because my pet feature isn't being added. The reality is that:

1. I don't care about ng-enabled, and I never have (though I am interested in being a contributor), and
2. I am frustrated that you asked, and then ignored for so many months.

Closing out the pull request/issue a couple of weeks later with a quick, "So we discussed this, and this looks great, but here are the reasons that we think it doesn't make sense in Angular going forward," would have stung much, much less than having sat in limbo for over nine months.

I guess, at the end of the day, it's still not clear to me – how can I help?