Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

browserTrigger doesn't support TouchEvent. #4997

Closed
munet9 opened this issue Nov 18, 2013 · 1 comment
Closed

browserTrigger doesn't support TouchEvent. #4997

munet9 opened this issue Nov 18, 2013 · 1 comment
Labels
component: scenario runner frequency: low PRs plz! type: bug
Milestone
ngTouch Overhaul

Comments

@munet9
Copy link

munet9 commented Nov 18, 2013

browserTrigger in ngScenario is very useful to triggering UIEvent and used in many spec files.
But browserTrigger(element, 'touchstart'); is triggering MouseEvent instead of TouchEvent.

This causes ngTouch tested uncorrectly.
TouchEvents has no clientX, clientY, But MouseEvent has these. So ngClick(ngTouch) with current browserTrigger will pass successfully, but with real touch-enabled device won't work.

I know Chrome, Firefox needs special flags in desktop.
Is it difficult to support TouchEvent in current browsers?

I think this fixes some issues(#2548, #3556, #4001, #4428, #4583).
@munet9 munet9 mentioned this issue Dec 10, 2013
Closed
@ghost ghost assigned tbosch Dec 10, 2013
munet9 added a commit to munet9/angular.js that referenced this issue Dec 10, 2013
@munet9
feat(browserTrigger): add support TouchEvent
b8eca81 
To simulate Touch-enabled device in ngTouch test.
```browserTrigger(element, 'touchstart')``` generates TouchEvent not MouseEvent.

Closes angular#4997
@cqr cqr mentioned this issue Jul 17, 2014
Closed
@btford btford removed the gh: issue label Aug 20, 2014
@petebacondarwin petebacondarwin modified the milestones: Backlog, ngTouch Overhaul Jan 26, 2016
@petebacondarwin
Copy link
Contributor

This was fixed by 06a9f0a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: scenario runner frequency: low PRs plz! type: bug
Projects
None yet
Milestone
ngTouch Overhaul
Development

Successfully merging a pull request may close this issue.

feat(browserTrigger): add support TouchEvent munet9/angular.js
4 participants
@petebacondarwin @munet9 @btford @tbosch