fix(ngTouch): ngClick directive does not use correct event with jQuery

[steelsojka]

The ngClick directive is not using the correct touch object when jQuery is loaded. This caused the coordinates to get mapped to undefined instead of the actual x and y coordinates. This logic was happening in multiple places so I extracted it into a function to help with simplicity.

[mary-poppins]

Thanks for the PR!

• Contributor signed CLA now or in the past
  • If you just signed, leave a comment here with your real name
• PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[auchenberg]

This issue seems to be a duplicate of #3556.

[steelsojka]

Although they both perform the same function, I feel like this is a cleaner and better way to do it. This removes duplicated logic and simplifies the code a bit. Things might start to get confusing at his point https://github.com/angular/angular.js/pull/3556/files#diff-6baa668d8987507ba9244376d3c69a14R232 when the originalEvent is getting checked for twice.

[auchenberg]

I agree. This is a cleaner implementation. I just faced the same issue, so I started looking in the issue-tracker, so this was a heads-up.

[steelsojka]

Yeah I did the same thing when I ran into this issue. I was hoping a fix would be implemented for 1.2 but no such luck.

[petebacondarwin]

This PR could do with some unit tests...
Also, I note that #3556 also makes changes to the $swipe service. Is this not needed for this patch?

[munet9]

$swipe service has originalEvent-fallback already.
https://github.com/angular/angular.js/blob/master/src/ngTouch/swipe.js#L31
So $swipe makes no errors. But it's better this is refactored together.

[steelsojka]

I added the same implementation to the $swipe service.

#3556 is accomplishing the same thing. I think this might be a cleaner solution.

I'm having trouble trying to accompany this with a unit test. Since it's a "private" method its hard to test that functionality explicitly. The stuff I can test against, like the event object, is already being tested for the same things I would check against. If anybody has any suggestions please let me know and I'll write the test. I'm just stumped right now.

[Narretz]

This was added as part of 06a9f0a