Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngTouch): replace event with originalEvent #3556

Closed
wants to merge 1 commit into from
Closed

fix(ngTouch): replace event with originalEvent #3556

wants to merge 1 commit into from

Conversation

jasonals
Copy link
Contributor

When jQuery is included touches are found on event.originalEvent

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@jasonals
Copy link
Contributor Author

Jason Als

@btford
Copy link
Contributor

btford commented Sep 30, 2013

Thanks for the PR, @jasonals

We need a test for this change. See this file for where to start: https://github.com/angular/angular.js/blob/master/test/ngTouch/directive/ngClickSpec.js

@ghost ghost assigned bshepherdson Oct 2, 2013
@btford
Copy link
Contributor

btford commented Oct 2, 2013

@shepheb can you look at this?

When jQuery is included touches are found on event.originalEvent
@jasonals
Copy link
Contributor Author

jasonals commented Oct 3, 2013

Checked and not sure how this would be tested apart from what is there already but I'll keep looking.

@btford btford removed the gh: PR label Aug 20, 2014
@jeffbcross jeffbcross force-pushed the master branch 2 times, most recently from cad9560 to f294244 Compare October 2, 2014 22:08
@jeffbcross jeffbcross force-pushed the master branch 4 times, most recently from e8dc429 to e83fab9 Compare October 10, 2014 17:37
@petebacondarwin petebacondarwin modified the milestones: Backlog, ngTouch Overhaul Jan 26, 2016
@petebacondarwin petebacondarwin removed this from the Backlog milestone Jan 26, 2016
@Narretz
Copy link
Contributor

Narretz commented Jan 26, 2016

This was actually added: 06a9f0a

@Narretz Narretz closed this Jan 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants