fix($location): remove query args when passed in object

[SekibOmazic]

Request Type:

How to reproduce:

Component(s): $location

Impact: small

Complexity: small

This issue is related to:

Detailed Description:

Please read the description from the issue #6565

Other Comments:

Query args will be removed from $location search object if they are passed in as null or undefined object properties.

Uses Object.keys() to fix the bug so it will not work for IE8

closes #6565

[mary-poppins]

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

• Uses the issue template (#6573)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[gsklee]

@SekibOmazic v1.2.x still supports IE8 so this probably will be a no-go. Any chance to implement it differently to take IE8 into account?

[SekibOmazic]

@gsklee I've changed it to use for..in with hasOwnProperty() which will work with IE8.

[gsklee]

@SekibOmazic Looks great! =)

[gsklee]

@SekibOmazic Just learned that v1.3 is on the way and might be hitting the road as soon as next week, which will dump IE8 support - so I guess you can disregard my previous footnote and revert back to the fancier implementation if you'd like to =)

[SekibOmazic]

@gsklee Well, let the core team decide what is preferred solution. I can switch back to Object.keys() easily.

[IgorMinar]

landed as 2c7d085
thanks!