This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Small improvements for bugs I ran into on mobile devices and older webkit browsers #6733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shstate as well, so we check on webkit versions older then 534.x.x to use history or not.
…as been updated, which causes validations to fail. Delaying the listener with 5 milliseconds solves the problem.
- Adds accessibility attributes to links and images. - Adds a note on using NVM for node.
Jasmine doesn't live at the replaced link anymore. It has a link to click through, but I figured it would be better to just go directly to the correct location. Closes #6591
The meta-data should be parsed from the name not the id.
If the first element in a template is a <thead> or a <tfoot>, then use the existing logic to handle table elements compilation. Closes #6289
The docs were relying on the grunt/util module for getting version info but this was unreliable and full of custom regexes. This is moved into a new version-info module that makes much better use of the semver library.
As highlighted by the new sterner dgeni.
In relation to angular/dgeni-packages#8 Closes #6641
`restictions` -> `restrictions` Closes #6604
A few typos fixed. Closes #6605
`preferrable` -> `preferable` Typo fixed Closes #6606
this is primarily to resolve peerdependency version mismatch issue
type-hint-regexp gets a nice color closes #6596
It might seem obvious that if you don't supply "bind" attribute in this case, you'll get an error, but I feel this is worth adding to the doc. Closes #6725
Updated example formatting. Closes #6068
This was introduced by 2ca6d65, somewhat inexplicably as I had run grunt ci-checks locally. But regardless, this should fix this up.
The changes to version-info meant that the version being injected into the code at build time was missing the "dot" (patch) version and the release code-name.
Fix click busting of input click triggered by a label click quickly following a touch event on a different element, in desktop and mobile WebKit To reproduce the issue fixed by this commit set up a page with - an element with ng-click - a radio button (with hg-model) and associated label In a quick sequence tap on the element and then on the label. The radio button will not be checked, unless PREVENT_DURATION has passed Closes #6302
Previously, non-string values stored in $cookies would be removed, without warning the user, and causing difficulty debugging. Now, the value is converted to string before being stored, and the value is not dropped. Serialization may be customized using the toString() method of an object's prototype. Closes #6151 Closes #6220
The orderBy filter now allows string predicates passed to the orderBy filter to make use property
name predicates containing non-ident strings, such as spaces or percent signs, or non-latin
characters.
This behaviour requires the predicate string to be double-quoted.
In markup, this might look like so:
```html
<div ng-repeat="item in items | orderBy:'\"Tip %\"'">
...
</div>
```
Or in JS:
```js
var sorted = $filter('orderBy')(array, ['"Tip %"', '-"Subtotal $"'], false);
```
Closes #6143
Closes #6144
$watchCollection checks if oldValue !== newValue which does not work for NaN. This was causing infinite digest errors, since comparing NaN to NaN in $watchCollection would always return false, indicating that a change was occuring on each loop. This fix adds a simple check to see if the current value and previous value are both NaN, and if so, does not count it as a change. Closes #4605
The Android 2.x browser is not ES5-compatible in that it does not allow use of reserved words as property names. This docs fix adds Android to the note to the `$q` docs which already make it known that string property notation should be used when using the `finally` method on `$q`.
The $document docs are pretty empty, and this fills them out a bit. The example itself may not be particularly useful, but it could be improved or removed later. Works for me. Closes #6757
… not throw fb6062f implements a fix for NaN values causing $watchCollection to throw an infdig error. This change updates the test by adding an assertion which explains what is actually being tested a bit better, and may also provide better information in the event that the test ever fails. Closes #6758
Conflicts: test/ng/snifferSpec.js
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
|
Sorry I haven't done it the correct way you can ignore this pull request, I should have put it on a seperate branch… |
|
Be sure to link your other PR to this one so that we can easily see the comments left on this one, thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request Type: bug
How to reproduce:
Create a multipage app in Angular v 1.2.6 that has some redirects, as soon as the app wants to redirect it ends up in an endless loop.
Extra components we use: angular-route, angular-sanitize, angularitics, ng-i18next
Component(s): misc core
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
Webkit browsers under version 534 don't support the history.pushState correctly, which breaks the routing in Angular and creates an endless loop on Safari and Android.
And on iOS7 there seems to be a delay of a couple of milliseconds before the value gets updated, but the input change event has already been fired. Which causes form validation issues.