This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(jqLite): use .children to fetch child elements but fallback to .childNodes for SVGs in IE #8075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e35abc9 broke
jqLiteDealoc
on SVG elements in IE because.children
is not supported on SVGs in IE (https://developer.mozilla.org/en-US/docs/Web/API/ParentNode.children#Browser_compatibility).This change adds an SVG test and fixes it by doing
.children || .childNodes
. I also added.children
in a few more places in addition to where e35abc9 originally did. Although if the.childNodes
fallback is always required for IE, is it still worth using.children
?