This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(jqLite): use getElementsByTagName for dealoc-ing elements, cz of SVG on IE #8136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method doesn't exist in jQuery, and there's shouldn't be any need for it
SVG elements in IE don't have a `.children` but only `.childNodes` so it broke. We started using `.children` for perf in e35abc9. This also acts as a perf improvements, since `getElementsByTagName` is faster than traversing the tree. Related angular#8075
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
I had a change (not committed) essentially doing the exact same thing including the onlyDescendants flag for html/empty, so I like it! :P I didn't try the |
|
LGTM |
|
Landed as 38bdb40...c61626f |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments in #8075