This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): Resolve various potential memory leaks (v1.2.x) #9326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop an asynchronous compilation when this is performed on an already destroyed scope Closes angular#9199 Closes angular#9079 Closes angular#8504 Closes angular#9197
|
@lgalfaso - can you give this a quick check? |
|
LGTM |
|
:-( travis doesn't like this... |
|
I believe the problem is that in 1.2.x our jqLite allows us to attach data to comment nodes. This allows us to set up the $destroy handlers inside the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a backport of #9079 to the stable branch.