This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Fixes bug when $location.search() is not returning search part of current url. Inluding tests. #9445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent url. Inluding tests.
@caitp could you please make a code review. |
@@ -475,6 +475,7 @@ LocationHashbangInHtml5Url.prototype = | |||
search = search.toString(); | |||
this.$$search = parseKeyValue(search); | |||
} else if (isObject(search)) { | |||
search = copy(search, {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should no-op when the passed search object is the same as the one returned from search()
, since it would be pointless work
lgtm, but I would add the no-op in the case I mentioned |
@@ -475,6 +475,7 @@ LocationHashbangInHtml5Url.prototype = | |||
search = search.toString(); | |||
this.$$search = parseKeyValue(search); | |||
} else if (isObject(search)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (search === this.$$search) return this;
@IgorMinar wdyt? I don't think it's a bug that hit's everyone, but it seems kinda buggy to me |
Lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue appears when we set $location.search() with some object and after that change this object's properties, like that:
There's a little demo onJSBin:
http://jsbin.com/rekana/5/edit?js,output
And another JSBin with behaviour fixed on consumer's side:
http://jsbin.com/rekana/1/edit?js,output
I'm sure it's a bad idea to make someone think of that on the consumer's side.