Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fixes bug when $location.search() is not returning search part of current url. Inluding tests. #9445

Closed
wants to merge 1 commit into from
Closed

Fixes bug when $location.search() is not returning search part of current url. Inluding tests. #9445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ng/location.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,7 @@ LocationHashbangInHtml5Url.prototype =
search = search.toString();
this.$$search = parseKeyValue(search);
} else if (isObject(search)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (search === this.$$search) return this;

search = copy(search, {});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should no-op when the passed search object is the same as the one returned from search(), since it would be pointless work

// remove object undefined or null properties
forEach(search, function(value, key) {
if (value == null) delete search[key];
Expand Down
10 changes: 10 additions & 0 deletions test/ng/locationSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,16 @@ describe('$location', function() {
});


it('search() should not use given object directly', function() {
var obj = {one: 1, two: true, three: null};
url.search(obj);
expect(obj).toEqual({one: 1, two: true, three: null});
obj.one = 'changed';
expect(url.search()).toEqual({one: 1, two: true});
expect(url.absUrl()).toBe('http://www.domain.com:9877/path/b?one=1&two#hash');
});


it('search() should change single parameter', function() {
url.search({id: 'old', preserved: true});
url.search('id', 'new');
Expand Down