Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(jqLite): remove native listener when all jqLite listeners were deregistered #9540

Closed
wants to merge 1 commit into from
Closed

fix(jqLite): remove native listener when all jqLite listeners were deregistered #9540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/jqLite.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,18 +274,22 @@ function jqLiteOff(element, type, fn, unsupported) {
if (!type) {
for (type in events) {
if (type !== '$destroy') {
removeEventListenerFn(element, type, events[type]);
removeEventListenerFn(element, type, handle);
}
delete events[type];
}
} else {
forEach(type.split(' '), function(type) {
if (isUndefined(fn)) {
removeEventListenerFn(element, type, events[type]);
delete events[type];
} else {
arrayRemove(events[type] || [], fn);
if (isDefined(fn)) {
var listenerFns = events[type];
arrayRemove(listenerFns || [], fn);
if (listenerFns && listenerFns.length > 0) {
return;
}
}

removeEventListenerFn(element, type, handle);
delete events[type];
});
}
}
Expand Down
88 changes: 88 additions & 0 deletions test/jqLiteSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1400,6 +1400,94 @@ describe('jqLite', function() {
expect(extraSpy).toHaveBeenCalledOnce();
});


describe('native listener deregistration', function() {

it('should deregister the native listener when all jqLite listeners for given type are gone ' +
'after off("eventName", listener) call', function() {
var aElem = jqLite(a);
var addEventListenerSpy = spyOn(aElem[0], 'addEventListener').andCallThrough();
var removeEventListenerSpy = spyOn(aElem[0], 'removeEventListener').andCallThrough();
var nativeListenerFn;

var jqLiteListener = function() {};
aElem.on('click', jqLiteListener);

expect(addEventListenerSpy).toHaveBeenCalledOnceWith('click', jasmine.any(Function), false);
nativeListenerFn = addEventListenerSpy.mostRecentCall.args[1];
expect(removeEventListenerSpy).not.toHaveBeenCalled();

aElem.off('click', jqLiteListener);
expect(removeEventListenerSpy).toHaveBeenCalledOnceWith('click', nativeListenerFn, false);
});


it('should deregister the native listener when all jqLite listeners for given type are gone ' +
'after off("eventName") call', function() {
var aElem = jqLite(a);
var addEventListenerSpy = spyOn(aElem[0], 'addEventListener').andCallThrough();
var removeEventListenerSpy = spyOn(aElem[0], 'removeEventListener').andCallThrough();
var nativeListenerFn;

aElem.on('click', function() {});
expect(addEventListenerSpy).toHaveBeenCalledOnceWith('click', jasmine.any(Function), false);
nativeListenerFn = addEventListenerSpy.mostRecentCall.args[1];
expect(removeEventListenerSpy).not.toHaveBeenCalled();

aElem.off('click');
expect(removeEventListenerSpy).toHaveBeenCalledOnceWith('click', nativeListenerFn, false);
});


it('should deregister the native listener when all jqLite listeners for given type are gone ' +
'after off("eventName1 eventName2") call', function() {
var aElem = jqLite(a);
var addEventListenerSpy = spyOn(aElem[0], 'addEventListener').andCallThrough();
var removeEventListenerSpy = spyOn(aElem[0], 'removeEventListener').andCallThrough();
var nativeListenerFn;

aElem.on('click', function() {});
expect(addEventListenerSpy).toHaveBeenCalledOnceWith('click', jasmine.any(Function), false);
nativeListenerFn = addEventListenerSpy.mostRecentCall.args[1];
addEventListenerSpy.reset();

aElem.on('dblclick', function() {});
expect(addEventListenerSpy).toHaveBeenCalledOnceWith('dblclick', nativeListenerFn, false);

expect(removeEventListenerSpy).not.toHaveBeenCalled();

aElem.off('click dblclick');

expect(removeEventListenerSpy).toHaveBeenCalledWith('click', nativeListenerFn, false);
expect(removeEventListenerSpy).toHaveBeenCalledWith('dblclick', nativeListenerFn, false);
expect(removeEventListenerSpy.callCount).toBe(2);
});


it('should deregister the native listener when all jqLite listeners for given type are gone ' +
'after off() call', function() {
var aElem = jqLite(a);
var addEventListenerSpy = spyOn(aElem[0], 'addEventListener').andCallThrough();
var removeEventListenerSpy = spyOn(aElem[0], 'removeEventListener').andCallThrough();
var nativeListenerFn;

aElem.on('click', function() {});
expect(addEventListenerSpy).toHaveBeenCalledOnceWith('click', jasmine.any(Function), false);
nativeListenerFn = addEventListenerSpy.mostRecentCall.args[1];
addEventListenerSpy.reset();

aElem.on('dblclick', function() {});
expect(addEventListenerSpy).toHaveBeenCalledOnceWith('dblclick', nativeListenerFn, false);

aElem.off();

expect(removeEventListenerSpy).toHaveBeenCalledWith('click', nativeListenerFn, false);
expect(removeEventListenerSpy).toHaveBeenCalledWith('dblclick', nativeListenerFn, false);
expect(removeEventListenerSpy.callCount).toBe(2);
});
});


// Only run this test for jqLite and not normal jQuery
if ( _jqLiteMode ) {
it('should throw an error if a selector is passed', function () {
Expand Down