This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(jqLite): remove native listener when all jqLite listeners were deregistered #9540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorMinar
changed the title
…registered This fixes an iOS issue where some events buble only when native listeners are present (see angular#9509), but more importantly previously we would pass wrong argument into the `removeEventListenerFn` which caused native listeners to be never deregistered. Oops! Closes angular#9509
IgorMinar
force-pushed
the
jqlite-off-fix
branch
from
be26eb6 to
babf2a4
Compare
|
LGTM, but I have no experience with jqLite. I restarted the failing job on Travis |
|
landed as d71fb6f |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...istered
This fixes an iOS issue where some events buble only when native listeners are present (see #9509),
but more importantly previously we would pass wrong argument into the
removeEventListenerFnwhichcaused native listeners to be never deregistered. Oops!
Closes #9509