build: update to nodejs rules 0.38.3 #33073
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@alexeagle Changes to external.bzl will need g3 equivalents |
Contributor
Author
|
@alexeagle @devversion Looks like we'll need to update material to 0.38.2 first to green this PR up. I'll make a PR in the morning if you don't get to it overnight @devversion . |
mhevery
approved these changes
Oct 10, 2019
mhevery
added
the
area: build & ci
Contributor
|
Note to caretaker: cl/271704225 has to land before this can get a green g3sync |
gregmagolan
changed the title
alexeagle
approved these changes
Oct 11, 2019
Some changes in rules_nodejs providers folded into @angular/bazel package: * `NodeModuleSources` renamed to `NpmPackageInfo` and now loaded from `//internal/common:npm_package_info.bzl` * `collect_node_modules_aspect` renamed to `node_modules_aspect` * new JS provider `JSNamedModuleInfo` now available and ng_module provides it using the `js_named_module_info` factory function * sources_aspect has also been removed so the use of the `node_sources` legacy provider has been replaced with `JSNamedModuleInfo`.
All providers now loaded from "@build_bazel_rules_nodejs//:providers.bzl".
Updates the `material-unit-test` job to run tests against the latest commit of the Angular Components repository. The components repository updated to rules_nodejs#0.38.2 before Angular Bazel did. To do this, the `@angular/bazel` v0.38.2 compatibility changes were patched on postinstall. This now conflicts because we install a `@angular/bazel` version in the `material-unit-tests` job that already includes these compatibility changes. This would result in the patch being a noop for which the `patch` command throws an error. We can remove this once components can install a released version of `@angular/bazel` that is compatible with `rules_nodejs#0.38.2`.
gregmagolan
added
the
area: bazel
Contributor
|
caretaker: g3sync presubmit |
alexeagle
added
action: merge
mhevery
pushed a commit
that referenced
this pull request
Oct 14, 2019
All providers now loaded from "@build_bazel_rules_nodejs//:providers.bzl". PR Close #33073
mhevery
pushed a commit
that referenced
this pull request
Oct 14, 2019
Updates the `material-unit-test` job to run tests against the latest commit of the Angular Components repository. The components repository updated to rules_nodejs#0.38.2 before Angular Bazel did. To do this, the `@angular/bazel` v0.38.2 compatibility changes were patched on postinstall. This now conflicts because we install a `@angular/bazel` version in the `material-unit-tests` job that already includes these compatibility changes. This would result in the patch being a noop for which the `patch` command throws an error. We can remove this once components can install a released version of `@angular/bazel` that is compatible with `rules_nodejs#0.38.2`. PR Close #33073
mhevery
pushed a commit
that referenced
this pull request
Oct 14, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes in rules_nodejs providers folded into @angular/bazel package:
NodeModuleSourcesrenamed toNpmPackageInfoand now loaded from//internal/common:npm_package_info.bzlcollect_node_modules_aspectrenamed tonode_modules_aspectJSNamedModuleInfonow available and ng_module provides it using thejs_named_module_infofactory functionnode_sourceslegacy provider has been replaced withJSNamedModuleInfo.