Skip to content

chore: update to nodejs rules 0.38.2 #17361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jelbourn merged 1 commit into from
Oct 10, 2019
Merged

chore: update to nodejs rules 0.38.2 #17361

jelbourn merged 1 commit into from
Oct 10, 2019

Conversation

@gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented Oct 10, 2019 •
edited
Loading

Pre-req for angular/angular#33073

@gregmagolan gregmagolan requested a review from jelbourn as a code owner October 10, 2019 18:18
@gregmagolan gregmagolan requested a review from a team October 10, 2019 18:18
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 10, 2019
@jelbourn
Copy link
Member

jelbourn commented Oct 10, 2019

Looks very red?

@devversion
Copy link
Member

devversion commented Oct 10, 2019 •
edited
Loading

Needs to update the runfiles for the npm repository in workspace I guess.

@gregmagolan
Copy link
Contributor Author

gregmagolan commented Oct 10, 2019

Looks very red?

I had to run to a lunch meeting just as I made this so looks like I missed a line :) Greening up now.

jelbourn
jelbourn approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Oct 10, 2019
@jelbourn jelbourn merged commit 43af4c2 into angular:master Oct 10, 2019
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gregmagolan @jelbourn @devversion @googlebot