Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raised buttons with colors are not following spec on focus #3820

Closed
Maistho opened this issue Mar 28, 2017 · 1 comment · Fixed by #3822
Closed

Raised buttons with colors are not following spec on focus #3820

Maistho opened this issue Mar 28, 2017 · 1 comment · Fixed by #3822

Comments

@Maistho
Copy link
Contributor

Maistho commented Mar 28, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Text color of raised buttons with color does not change on focus
Background-color of raised buttons with color changes on focus

What is the current behavior?

Text color of raised buttons with color changes on focus
Background-color of raised buttons with color does not on focus

What are the steps to reproduce?

Here is a plunker that shows the issue
http://plnkr.co/edit/36A2DKgGGP4PtFfBrBtO?p=preview

What is the use-case or motivation for changing an existing behavior?

It should follow the spec

Which versions of Angular, Material, OS, browsers are affected?

Latest master has this issue
willshowell added a commit to willshowell/material2 that referenced this issue Mar 28, 2017
@willshowell
Use correct focus overlay for raised buttons
b31e6e1 
- Only uses themed overlay for flat buttons and flat icon buttons
- Dark overlay applies to all other buttons
- Fixes angular#3820
@willshowell willshowell mentioned this issue Mar 28, 2017
Merged
willshowell added a commit to willshowell/material2 that referenced this issue Apr 11, 2017
@willshowell
Use correct focus overlay for raised buttons
b35691b 
- Only uses themed overlay for flat buttons and flat icon buttons
- Dark overlay applies to all other buttons
- Fixes angular#3820
willshowell added a commit to willshowell/material2 that referenced this issue Apr 27, 2017
@willshowell
Use correct focus overlay for raised buttons
8b55f8c 
- Only uses themed overlay for flat buttons and flat icon buttons
- Dark overlay applies to all other buttons
- Fixes angular#3820
mmalerba pushed a commit that referenced this issue Apr 28, 2017
@willshowell @mmalerba
Use correct focus overlay for raised buttons (#3822)
16f5c30 
- Only uses themed overlay for flat buttons and flat icon buttons
- Dark overlay applies to all other buttons
- Fixes #3820
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style(button): correct focus overlay for raised buttons willshowell/material2
1 participant
@Maistho