style(button): correct focus overlay for raised buttons #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
willshowell
force-pushed
the
fix-button-focus-color
branch
from
b31e6e1 to
b35691b
Compare
|
Before After Spec |
|
Looking forward to having this assigned/reviewed! |
- Only uses themed overlay for flat buttons and flat icon buttons - Dark overlay applies to all other buttons - Fixes angular#3820
willshowell
force-pushed
the
fix-button-focus-color
branch
from
b35691b to
8b55f8c
Compare
|
@jelbourn any chance of getting this assigned? |
crisbeto
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The themed overlay was being added to all buttons, but should only be applied to flat or flat icon buttons. Raised buttons should use the default
rgba(black, 0.12)focus overlay color defined inbutton.scssFixes #3820