Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: typings are invalid for e2e tsconfig #630

Closed
devversion opened this issue Jun 4, 2016 · 2 comments
Closed

e2e: typings are invalid for e2e tsconfig #630

devversion opened this issue Jun 4, 2016 · 2 comments

Comments

@devversion
Copy link
Member

It seems like the e2e are always failing locally and on the CI, because of some incorrect typings.

image

See for example, CI job: https://travis-ci.org/angular/material2/jobs/135156835

Those typings are quite outdated and hard-copied into the repository. We should better install the typings from the typings manager

As a temporary fix, we can remove the node typings from the e2e typings. (those aren't used yet)
Once we upgrade typescript we can re-introduce the node typings again.
devversion added a commit to devversion/material2 that referenced this issue Jun 4, 2016
@devversion
fix(e2e): remove static typings and use typings manager
1b653dc 
* Removes static typings and uses the typings manager
* Fixes duplicate identifier issue of Typescript temporary

 - See microsoft/TypeScript#8737

Fixes angular#630.
@devversion devversion mentioned this issue Jun 4, 2016
Closed
devversion added a commit to devversion/material2 that referenced this issue Jun 4, 2016
@devversion
fix(e2e): remove static typings and use typings manager
c7dcc36 
* Removes static typings and uses the typings manager
* Fixes duplicate identifier issue of Typescript temporary

 - See microsoft/TypeScript#8737

Fixes angular#630.
devversion added a commit to devversion/material2 that referenced this issue Jun 4, 2016
@devversion
fix(e2e): remove static typings and use typings manager
d9f2159 
* Removes static typings and uses the typings manager
* Fixes duplicate identifier issue of Typescript temporary

 - See microsoft/TypeScript#8737

Fixes angular#630.
@devversion
Copy link
Member Author

Fixed with SHA a68597e

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(e2e): remove static typings and use typings manager devversion/material2
1 participant
@devversion