fix(e2e): remove static typings and use typings manager #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
fix/e2e-typings-are-invalid
branch
from
1b653dc
to
c7dcc36
Compare
* Removes static typings and uses the typings manager * Fixes duplicate identifier issue of Typescript temporary - See microsoft/TypeScript#8737 Fixes angular#630.
devversion
force-pushed
the
fix/e2e-typings-are-invalid
branch
2 times, most recently
from
bbba2f4
to
c160c25
Compare
devversion
force-pushed
the
fix/e2e-typings-are-invalid
branch
from
c160c25
to
0f6ad5a
Compare
|
FYI: We'll probably go with #637 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the E2E tests working on the CI, so the tests will probably fail, but the test fixes should be definitely addressed in another PR.
Darn it 😄 those much file deletions look weird ;P
Fixes #630.